Skip to content

feat(sig): Report list toolbar as core control#1532

Merged
Twixes merged 2 commits intomainfrom
twix/inbox-selection-ux
Apr 8, 2026
Merged

feat(sig): Report list toolbar as core control#1532
Twixes merged 2 commits intomainfrom
twix/inbox-selection-ux

Conversation

@Twixes
Copy link
Copy Markdown
Member

@Twixes Twixes commented Apr 7, 2026

Problem

The inbox list toolbar introduced in #1513 added controls only for bulk operations. But the same controls have been missing for individual reports too. In the Cloud version, we had them under a dropdown in the report pane itself. I considered doing the same here, but there's no point when we have a great toolbar - the toolbar should be the individual report controls as well.

At the same time, checkboxes take away from the content when shown always - and we don't need them by default for most user interactions here. (Ofc will validate this, but at least I think that's a safe assumption for now that the individual report level is the primary one.)

Changes

Making the report list toolbar always-on, with intuitive logic for selection state synced with the currently-viewed-report state. Unifies the selection state, so that "currently viewed" and "selected" are the same thing. Checkboxes only show up when multiple reports are selected. For multi-select, you can use the "Select all" checkbox or standard desktop Shift/Cmd+click patterns. See in action:

Copy link
Copy Markdown
Member Author

Twixes commented Apr 7, 2026

@Twixes Twixes force-pushed the twix/inbox-row-visuals branch from c53762d to f96bd7a Compare April 7, 2026 19:57
@Twixes Twixes force-pushed the twix/inbox-selection-ux branch from 67f9a59 to af669e3 Compare April 7, 2026 19:57
@Twixes Twixes force-pushed the twix/inbox-row-visuals branch from f96bd7a to 3971708 Compare April 7, 2026 20:00
@Twixes Twixes force-pushed the twix/inbox-selection-ux branch from af669e3 to 0e246ba Compare April 7, 2026 20:00
@Twixes Twixes changed the title Rework inbox bulk selection UX s Apr 7, 2026
@Twixes Twixes changed the title s feat(sig): Always show report controls Apr 7, 2026
@Twixes Twixes changed the title feat(sig): Always show report controls feat(sig): Make report list toolbar always-on Apr 7, 2026
@Twixes Twixes force-pushed the twix/inbox-row-visuals branch from 3971708 to ae4d475 Compare April 7, 2026 20:41
@Twixes Twixes force-pushed the twix/inbox-selection-ux branch from 0e246ba to 8f8f5fb Compare April 7, 2026 20:41
@Twixes Twixes force-pushed the twix/inbox-row-visuals branch from ae4d475 to 57e72a2 Compare April 7, 2026 21:18
@Twixes Twixes force-pushed the twix/inbox-selection-ux branch from 8f8f5fb to 200faf9 Compare April 7, 2026 21:18
@oliverb123 oliverb123 force-pushed the twix/inbox-row-visuals branch from 57e72a2 to 8e02e34 Compare April 7, 2026 21:51
@oliverb123 oliverb123 force-pushed the twix/inbox-selection-ux branch from 200faf9 to 7f9bc81 Compare April 7, 2026 21:52
@Twixes Twixes force-pushed the twix/inbox-selection-ux branch from 7f9bc81 to ea177bc Compare April 8, 2026 06:16
@Twixes Twixes force-pushed the twix/inbox-row-visuals branch from 8e02e34 to da7746d Compare April 8, 2026 06:16
@Twixes Twixes force-pushed the twix/inbox-selection-ux branch from ea177bc to e0e00eb Compare April 8, 2026 06:55
@Twixes Twixes changed the title feat(sig): Make report list toolbar always-on feat(sig): Report list toolbar as core control Apr 8, 2026
@Twixes Twixes force-pushed the twix/inbox-selection-ux branch from e0e00eb to 5a7e2ab Compare April 8, 2026 08:38
@Twixes Twixes force-pushed the twix/inbox-row-visuals branch from da7746d to 41031df Compare April 8, 2026 08:38
@Twixes Twixes marked this pull request as ready for review April 8, 2026 08:40
@Twixes Twixes requested a review from a team April 8, 2026 08:40
@Twixes Twixes force-pushed the twix/inbox-selection-ux branch 2 times, most recently from 5fb9697 to 7b212dd Compare April 8, 2026 09:59
Copy link
Copy Markdown
Member Author

Twixes commented Apr 8, 2026

Merge activity

  • Apr 8, 10:43 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 8, 10:56 AM UTC: Graphite couldn't merge this pull request because a downstack PR feat(sig): Inbox toolbar disabled clarity #1531 failed to merge.
  • Apr 8, 2:22 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Apr 8, 2:22 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Apr 8, 3:06 PM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (GitHub is reporting that this PR is not mergeable, despite passing required status checks defined by your branch protection rules. Please check your rulesets for additional blocking criteria. Graphite Merge Queue does not currently support rulesets. Please contact Graphite support for further assistance.).

@Twixes Twixes changed the base branch from twix/inbox-row-visuals to graphite-base/1532 April 8, 2026 10:55
@Twixes Twixes force-pushed the twix/inbox-selection-ux branch from 7b212dd to 9464ed0 Compare April 8, 2026 11:51
@Twixes Twixes force-pushed the graphite-base/1532 branch from 41031df to 2c6c682 Compare April 8, 2026 11:51
@Twixes Twixes changed the base branch from graphite-base/1532 to twix/inbox-row-visuals April 8, 2026 11:52
@Twixes Twixes changed the base branch from twix/inbox-row-visuals to graphite-base/1532 April 8, 2026 14:18
@Twixes Twixes force-pushed the twix/inbox-selection-ux branch from af34046 to 05ffbce Compare April 8, 2026 14:25
@Twixes Twixes force-pushed the graphite-base/1532 branch from 2c6c682 to d044bac Compare April 8, 2026 14:25
@Twixes Twixes changed the base branch from graphite-base/1532 to main April 8, 2026 14:25
@Twixes Twixes merged commit 52cfd23 into main Apr 8, 2026
12 of 15 checks passed
@Twixes Twixes deleted the twix/inbox-selection-ux branch April 8, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants